mardi 17 mars 2015

Why is a struct member uninitialized after dereferencing the struct


I'm writing an HBridge class to make handling HBridges one arduino much easier. I'm not sure why when I call .print() on my HBridge instance, it prints:



---------
BRIDGE ONE
Bridge Use:->pin: 1392293344
Bridge Idle->pin: 1392293408
Freq:0
Dir:0
---------
BRIDGE TWO
Bridge Use:->pin: 8
Bridge Idle->pin: 214125355
Freq:0
Dir:0


Notice how the Bridge Use and Bridge Idle is uninitialized. Am I making a mistake somewhere with my pointers?


Here is my code.


HBridge.h



//-----------------------|
#define true 1 //|
#define false 0 //|
//-----------------------|
#define PIN_OFF 0 //|
#define PIN_ON 1 //|
//-----------------------|
#define PIN_FORWARD 0 //|
#define PIN_BACKWARD 1//|
//-----------------------|



typedef struct{
int pin;
} Pin;

typedef struct {
Pin *inuse;
Pin *idle;
int freq;
int direction;
}Bridge;

typedef enum{ A, B} hbridge_pins;

class HBridge {
private:
Bridge bridge_a, bridge_b;
Bridge *pins[2];
public:
HBridge(int, int, int, int);
void setPinFrequency(hbridge_pins, int);
void setPinDir(hbridge_pins, int);
void turnPinOFF(hbridge_pins);
void update(void);
void print();
};


HBridge.cpp



#import "./HBridge.h"
#import <stdio.h>


Pin pinWith(int num) {
// pinMode(num, OUTPUT);
Pin p;
p.pin = num;
return p;
}

void swap_pins(Pin *a, Pin *b) {
Pin temp = *a;
*a = *b;
*b = temp;
}

void print_pin(const char * name, Pin *p){
printf("%s->pin: %d\n",name,p->pin);
}
void print_bridge(Bridge *b){
print_pin("Bridge Use:", b->inuse);
print_pin("Bridge Idle", b->idle);
printf("Freq:%d\nDir:%d\n",b->freq,b->direction);

}

void HBridge::turnPinOFF(hbridge_pins pin) {
pins[pin]->freq = PIN_OFF;
}

HBridge::HBridge(int pinAA, int pinAB, int pinBA, int pinBB) {

Pin a_use = pinWith(pinAA);
Pin a_idle = pinWith(pinAB);
Pin b_use = pinWith(pinBA);
Pin b_idle = pinWith(pinBB);


bridge_a.inuse = &a_use;
bridge_a.idle = &a_idle;

bridge_b.inuse = &b_use;
bridge_b.idle = &b_idle;




/*---(DEFAULT DIRECTIONS)---*/
bridge_a.direction = PIN_FORWARD;
bridge_b.direction = PIN_FORWARD;
bridge_a.freq = PIN_OFF;
bridge_b.freq = PIN_OFF;

/*---(ARRAY OF POINTERS TO THE TWO PINS FOR EASY ACCESS BY INDEX)---*/
pins[0] =&bridge_a;
pins[1] =&bridge_b;
}

void HBridge::setPinFrequency(hbridge_pins pin, int freq) {
pins[pin]->freq = freq;
}

void HBridge::setPinDir(hbridge_pins pin, int dir) {
if ((pins[pin]->direction == PIN_FORWARD && dir == PIN_FORWARD) || (pins[pin]->direction == PIN_BACKWARD && dir == PIN_BACKWARD)) {

} else if (pins[pin]->direction == PIN_FORWARD && dir == PIN_BACKWARD) {

/*----(SWAP POINTERS)----*/
swap_pins(pins[pin]->inuse, pins[pin]->idle);
pins[pin]->direction = PIN_BACKWARD;

} else if (pins[pin]->direction == PIN_BACKWARD && dir == PIN_FORWARD) {

/*----(SWAP POINTERS)----*/
swap_pins(pins[pin]->inuse, pins[pin]->idle);
pins[pin]->direction = PIN_BACKWARD;

}
}

void HBridge::update(void)/*pointer to an int to save memory*/ {
/*THE FIRST BRIDGE*/
// analogWrite(pins[0]->inuse->pin, pins[0]->freq);
// analogWrite(pins[0]->indle->pin, pins[0]->PIN_OFF);

// THE SECOND BRIDGE
// analogWrite(pins[1]->inuse->pin, pins[1]->freq);
// analogWrite(pins[1]->indle->pin, pins[1]->PIN_OFF);
}

void HBridge::print(void){

printf("---------\nBRIDGE ONE\n");
print_bridge(pins[0]);

printf("---------\nBRIDGE TWO\n");
print_bridge(pins[1]);
}


int main(int argc, const char*argv[]){
HBridge b(31,42,33,4);
b.setPinFrequency(A,200);
b.print();
}


I got it to work:



...
bridge_a.inuse = (Pin *)malloc(sizeof(Pin));
bridge_a.idle = (Pin *)malloc(sizeof(Pin));

bridge_b.inuse = (Pin *)malloc(sizeof(Pin));
bridge_b.idle = (Pin *)malloc(sizeof(Pin));

memcpy(bridge_a.inuse, &a_use, sizeof(Pin));
memcpy(bridge_a.idle, &a_idle, sizeof(Pin));
memcpy(bridge_b.inuse, &b_use, sizeof(Pin));
memcpy(bridge_b.idle, &b_idle, sizeof(Pin));
...



Aucun commentaire:

Enregistrer un commentaire